Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 830853003: Fix for moving to previous url from PDF page in OOP case. (Closed)

Created:
5 years, 11 months ago by Deepak
Modified:
5 years, 11 months ago
Reviewers:
gene, raymes
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for moving to previous url from PDF page in OOP case. alt,shift,ctrl are not considered while handling left or right arrow key in OOP case in PDF. Check added so that when left/right arrow key is selected then navigation with in the page will happen when alt,ctrl,shift are not selected. else default handling happen. BUG=446162 Committed: https://crrev.com/f58a0ec56b77d86d206cd703efee94a7c6513aab Cr-Commit-Position: refs/heads/master@{#310045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 2 chunks +20 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Deepak
OOP case issue, we have fixed this issue in in process case earlier. PTAL
5 years, 11 months ago (2015-01-05 13:15:04 UTC) #2
raymes
lgtm
5 years, 11 months ago (2015-01-05 22:51:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830853003/1
5 years, 11 months ago (2015-01-06 02:43:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 03:52:23 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 03:54:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f58a0ec56b77d86d206cd703efee94a7c6513aab
Cr-Commit-Position: refs/heads/master@{#310045}

Powered by Google App Engine
This is Rietveld 408576698