net/socket/ssl_client_socket_nss.cc - Issue 8308009: Fix a potential CFRelease(NULL).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 8308009: Fix a potential CFRelease(NULL). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: oh man Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_nss.cc

diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc

index bd7117d77c1700ebf01002b1fe4f16ac6d44722d..127394098085bf8c9cb78ed0ca598ac3234055c9 100644

--- a/net/socket/ssl_client_socket_nss.cc

+++ b/net/socket/ssl_client_socket_nss.cc

@@ -2383,8 +2383,11 @@ SECStatus SSLClientSocketNSS::PlatformClientAuthHandler(

}

if (os_error == noErr) {

- int cert_count = CFArrayGetCount(chain);

- CFRelease(chain);

+ int cert_count = 0;

+ if (chain) {

+ cert_count = CFArrayGetCount(chain);

+ CFRelease(chain);

+ }

that->net_log_.AddEvent(NetLog::TYPE_SSL_CLIENT_CERT_PROVIDED,

make_scoped_refptr(new NetLogIntegerParameter("cert_count",

cert_count)));

« no previous file with comments | « no previous file | no next file » | no next file with comments »