chrome/browser/ui/webui/ntp/ntp_resource_cache.cc - Issue 830743003: Directly inline shared WebUI CSS declarations into the security and supervised user interstitials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Issue 830743003: Directly inline shared WebUI CSS declarations into the security and supervised user interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: review Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/supervised_user/supervised_user_interstitial.cc ('K') | « chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc ('k') | chrome/browser/ui/webui/options/options_ui.cc » ('j') | ui/base/webui/web_ui_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

diff --git a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

index 105ac6bd96c8944b479243d4ce37c74a57ab95c1..099df67b638cf07a14b55367678f333ba15d411e 100644

--- a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

+++ b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

@@ -324,7 +324,7 @@ void NTPResourceCache::CreateNewTabIncognitoHTML() {

profile_->GetPrefs()->GetBoolean(bookmarks::prefs::kShowBookmarkBar);

localized_strings.SetBoolean("bookmarkbarattached", bookmark_bar_attached);

- webui::SetFontAndTextDirection(&localized_strings);

+ webui::SetTextDirection(&localized_strings);

static const base::StringPiece incognito_tab_html(

ResourceBundle::GetSharedInstance().GetRawDataResource(

@@ -377,7 +377,7 @@ void NTPResourceCache::CreateNewTabGuestHTML() {

l10n_util::GetStringUTF16(guest_tab_link_ids));

localized_strings.SetString("learnMoreLink", guest_tab_link);

- webui::SetFontAndTextDirection(&localized_strings);

+ webui::SetTextDirection(&localized_strings);

static const base::StringPiece guest_tab_html(

ResourceBundle::GetSharedInstance().GetRawDataResource(guest_tab_ids));

@@ -516,7 +516,7 @@ void NTPResourceCache::CreateNewTabHTML() {

NewTabPageHandler::GetLocalizedValues(profile_, &load_time_data);

NTPLoginHandler::GetLocalizedValues(profile_, &load_time_data);

- webui::SetFontAndTextDirection(&load_time_data);

+ webui::SetTextDirection(&load_time_data);

// Control fade and resize animations.

load_time_data.SetBoolean("anim",