Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4685)

Unified Diff: chrome/browser/supervised_user/supervised_user_interstitial.cc

Issue 830743003: Directly inline shared WebUI CSS declarations into the security and supervised user interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: review Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/supervised_user_interstitial.cc
diff --git a/chrome/browser/supervised_user/supervised_user_interstitial.cc b/chrome/browser/supervised_user/supervised_user_interstitial.cc
index f753e9d3297227ee8af0735c8f2a160625abfe61..e4683bffba8eb4b7a204d4978fd053b3dcc72763 100644
--- a/chrome/browser/supervised_user/supervised_user_interstitial.cc
+++ b/chrome/browser/supervised_user/supervised_user_interstitial.cc
@@ -267,10 +267,13 @@ std::string SupervisedUserInterstitial::GetHTMLContents() {
strings.SetString("requestSentMessage", request_sent_message);
strings.SetString("requestFailedMessage", request_failed_message);
- webui::SetFontAndTextDirection(&strings);
+ webui::SetTextDirection(&strings);
- base::StringPiece html(ResourceBundle::GetSharedInstance().GetRawDataResource(
- IDR_SUPERVISED_USER_BLOCK_INTERSTITIAL_HTML));
+ std::string html =
+ ResourceBundle::GetSharedInstance()
+ .GetRawDataResource(IDR_SUPERVISED_USER_BLOCK_INTERSTITIAL_HTML)
+ .as_string();
Dan Beam 2015/01/21 19:21:41 i don't really care much, and this could be clant-
Bernhard Bauer 2015/01/21 22:47:50 Hm, I think for method calls the dot on the beginn
+ webui::AppendWebUICSSTextDefaults(&html);
return webui::GetI18nTemplateHtml(html, &strings);
}

Powered by Google App Engine
This is Rietveld 408576698