Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: ui/base/webui/web_ui_util.h

Issue 830743003: Directly inline shared WebUI CSS declarations into the security and supervised user interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/webui/web_ui_util.h
diff --git a/ui/base/webui/web_ui_util.h b/ui/base/webui/web_ui_util.h
index 84e06f3170be5d3e336a932458efc5d5447f4f25..955ede0d198ca20bd7249111b407f92b475b28de 100644
--- a/ui/base/webui/web_ui_util.h
+++ b/ui/base/webui/web_ui_util.h
@@ -47,9 +47,18 @@ UI_BASE_EXPORT void ParsePathAndScale(const GURL& url,
// Helper function to set the font family, size, and text direction into the
// given dictionary.
+// Note that using JS templates to set these attributes might lead to flicker.
+// An alternative is to use AppendWebUICSSTextDefaults() below.
felt 2015/01/10 01:00:41 nit: If this is being deprecated, should it say so
Bernhard Bauer 2015/01/12 15:47:17 Per Jungshik's comment in supervised_user_block_in
UI_BASE_EXPORT void SetFontAndTextDirection(
base::DictionaryValue* localized_strings);
+// Get a CSS declaration for common text styles for all of Web UI.
+UI_BASE_EXPORT std::string GetWebUICSSTextDefaults();
+
+// Appends the CSS declaration returned by GetWebUICSSTextDefaults() as an
+// inline stylesheet.
+UI_BASE_EXPORT void AppendWebUICSSTextDefaults(std::string* html);
+
// Get some common font styles for all of WebUI.
UI_BASE_EXPORT std::string GetFontFamily();
UI_BASE_EXPORT std::string GetFontSize();

Powered by Google App Engine
This is Rietveld 408576698