Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 830743002: debugger: Make inspector widget smaller (Closed)

Created:
5 years, 11 months ago by Kimmo Kinnunen
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@debugger-resize-02-drawop-view-resize
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

debugger: Make inspector widget smaller Make inspector widget a bit smaller by letting the Qt widget system layout the widgets. Let the inspector widget calculate its own smallest size. Use stretch factor of 0 for inspector, 1 for picture canvas. Group the matrix and clip widgets in groups. Put the text edits in a grid layout instead of a handwritted column layout containing row layouts. This commit is part of work that tries to make the debugger window to be a bit more resizeable, so that it would fit 1900x1200 screen. Committed: https://skia.googlesource.com/skia/+/7c339ae1e362e9f02cdfb9b32007f143dec0bc0e

Patch Set 1 #

Total comments: 4

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -78 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 2 chunks +2 lines, -6 lines 0 comments Download
M debugger/QT/SkInspectorWidget.h View 3 chunks +9 lines, -11 lines 0 comments Download
M debugger/QT/SkInspectorWidget.cpp View 1 4 chunks +31 lines, -61 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Kimmo Kinnunen
5 years, 11 months ago (2014-12-31 07:34:38 UTC) #2
robertphillips
lgtm + some nits https://codereview.chromium.org/830743002/diff/1/debugger/QT/SkInspectorWidget.cpp File debugger/QT/SkInspectorWidget.cpp (right): https://codereview.chromium.org/830743002/diff/1/debugger/QT/SkInspectorWidget.cpp#newcode12 debugger/QT/SkInspectorWidget.cpp:12: static const int ? https://codereview.chromium.org/830743002/diff/1/debugger/QT/SkInspectorWidget.cpp#newcode38 ...
5 years, 11 months ago (2014-12-31 21:06:53 UTC) #3
Kimmo Kinnunen
https://codereview.chromium.org/830743002/diff/1/debugger/QT/SkInspectorWidget.cpp File debugger/QT/SkInspectorWidget.cpp (right): https://codereview.chromium.org/830743002/diff/1/debugger/QT/SkInspectorWidget.cpp#newcode12 debugger/QT/SkInspectorWidget.cpp:12: On 2014/12/31 21:06:52, robertphillips wrote: > static const int ...
5 years, 11 months ago (2015-01-02 07:17:54 UTC) #4
Kimmo Kinnunen
https://codereview.chromium.org/830743002/diff/1/debugger/QT/SkInspectorWidget.cpp File debugger/QT/SkInspectorWidget.cpp (right): https://codereview.chromium.org/830743002/diff/1/debugger/QT/SkInspectorWidget.cpp#newcode12 debugger/QT/SkInspectorWidget.cpp:12: On 2014/12/31 21:06:52, robertphillips wrote: > static const int ...
5 years, 11 months ago (2015-01-02 07:17:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830743002/20001
5 years, 11 months ago (2015-01-02 07:18:22 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-02 14:35:47 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7c339ae1e362e9f02cdfb9b32007f143dec0bc0e

Powered by Google App Engine
This is Rietveld 408576698