Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issue 830733004: Removing dead code setNumberViews (Closed)

Created:
5 years, 11 months ago by Paritosh Kumar
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing dead code setNumberViews BUG=137718 Committed: https://crrev.com/e5cf923088ed0ce5825f82c4aa325af6ff0a098f Cr-Commit-Position: refs/heads/master@{#311116}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M chrome/common/crash_keys.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Paritosh Kumar
Please have a look.
5 years, 11 months ago (2015-01-12 06:39:31 UTC) #2
Lei Zhang
You should remove crash_keys::kNumberOfViews as well.
5 years, 11 months ago (2015-01-12 08:48:28 UTC) #3
Paritosh Kumar
On 2015/01/12 08:48:28, Lei Zhang wrote: > You should remove crash_keys::kNumberOfViews as well. Thanks Lei. ...
5 years, 11 months ago (2015-01-12 09:50:49 UTC) #4
jam
lgtm
5 years, 11 months ago (2015-01-12 18:05:05 UTC) #5
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-12 19:08:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830733004/20001
5 years, 11 months ago (2015-01-12 19:09:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/93617)
5 years, 11 months ago (2015-01-12 20:16:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830733004/20001
5 years, 11 months ago (2015-01-12 21:16:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-12 21:58:20 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 21:59:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5cf923088ed0ce5825f82c4aa325af6ff0a098f
Cr-Commit-Position: refs/heads/master@{#311116}

Powered by Google App Engine
This is Rietveld 408576698