Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: content/browser/devtools/renderer_overrides_handler_browsertest.cc

Issue 83073008: Do not leak a DictionaryValue from RendererOverridesHandlerTest.QueryUsageAndQuota. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/renderer_overrides_handler_browsertest.cc
diff --git a/content/browser/devtools/renderer_overrides_handler_browsertest.cc b/content/browser/devtools/renderer_overrides_handler_browsertest.cc
index dbe3d1a822d2533299a6931cff7b036364992799..24dd9621341dc4564fab62c9906b99bbf3fd7afe 100644
--- a/content/browser/devtools/renderer_overrides_handler_browsertest.cc
+++ b/content/browser/devtools/renderer_overrides_handler_browsertest.cc
@@ -74,11 +74,11 @@ class RendererOverridesHandlerTest : public ContentBrowserTest {
}
void OnMessageSent(const std::string& message) {
- base::DictionaryValue* root =
- static_cast<base::DictionaryValue*>(base::JSONReader::Read(message));
+ scoped_ptr<base::DictionaryValue> root(
+ static_cast<base::DictionaryValue*>(base::JSONReader::Read(message)));
base::DictionaryValue* result;
root->GetDictionary("result", &result);
- result_.reset(result);
+ result_.reset(result->DeepCopy());
base::MessageLoop::current()->QuitNow();
}
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698