Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 83073008: Do not leak a DictionaryValue from RendererOverridesHandlerTest.QueryUsageAndQuota. (Closed)

Created:
7 years, 1 month ago by earthdok
Modified:
7 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Do not leak a DictionaryValue from RendererOverridesHandlerTest.QueryUsageAndQuota. Fix memory leak in content_browsertests discovered by LeakSanitizer. BUG=307043 TBR=pfeldman@chromium.org TEST=content_browsertests:RendererOverridesHandlerTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/devtools/renderer_overrides_handler_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
earthdok
PTAL
7 years, 1 month ago (2013-11-22 20:46:46 UTC) #1
earthdok
Committed patchset #1 manually as r236833 (presubmit successful).
7 years, 1 month ago (2013-11-22 21:38:24 UTC) #2
pfeldman
7 years ago (2013-11-23 15:20:12 UTC) #3
Message was sent while issue was closed.
Thanks

Powered by Google App Engine
This is Rietveld 408576698