tools/lexer_generator/code_generator.jinja - Issue 83073004: Experimental parser: fix off by one error in utf8 decoding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/lexer_generator/code_generator.jinja

Issue 83073004: Experimental parser: fix off by one error in utf8 decoding (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/parser

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/lexer_generator/code_generator.jinja

diff --git a/tools/lexer_generator/code_generator.jinja b/tools/lexer_generator/code_generator.jinja

index f118166ce03c5557d95cd24c394421e2397fb344..e131b7cd1393289f3caa65d78b24f307cec0f88e 100644

--- a/tools/lexer_generator/code_generator.jinja

+++ b/tools/lexer_generator/code_generator.jinja

@@ -94,7 +94,7 @@

reinterpret_cast<uint8_t*>(cursor_),

buffer_end_ - cursor_,

&bytes_read);

- cursor_ += bytes_read;

+ cursor_ += bytes_read - 1;

if (long_char == unibrow::Utf8::kBadChar) goto default_action;

{%- else -%}

uncompilable code for {{encoding}}

« no previous file with comments | « no previous file | no next file » | no next file with comments »