Issue 83073003: Get rid of the binop_stub parameter to BuildBinaryOperation().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83073003: Get rid of the binop_stub parameter to BuildBinaryOperation(). (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer

Modified:
7 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Get rid of the binop_stub parameter to BuildBinaryOperation(). Just ask the graph builder whether we are compiling a stub. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18004

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -12 lines)			Patch
M	src/code-stubs-hydrogen.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/hydrogen.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

Hey Sven, This is trivial cleanup. PTAL -- Benedikt

7 years, 1 month ago (2013-11-22 10:27:01 UTC) #1

Benedikt Meurer

7 years, 1 month ago (2013-11-22 11:49:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18004 (presubmit successful).