Issue 83073002: Fix gyptest-sdkroot when oldest SDK is >= 10.8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83073002: Fix gyptest-sdkroot when oldest SDK is >= 10.8 (Closed)

Created:
7 years, 1 month ago by sdefresne

Modified:
7 years ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix gyptest-sdkroot when oldest SDK is >= 10.8 When using Mac OS X Mavericks with Xcode 5.0.2, the only SDK installed are 10.8 and 10.9. Fix the test by using the oldest installed and supported SDK. BUG=381 R=mark@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1810

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -17 lines)			Patch
	M	test/mac/gyptest-sdkroot.py	View		1 chunk	+22 lines, -15 lines	0 comments	Download
	M	test/mac/sdkroot/test_shorthand.sh	View		1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

The tests don’t seem to have run on this one, can you try again?

7 years ago (2013-12-06 20:12:08 UTC) #2

Mark Mentovai

Sorry for the delay on all of these. For almost all of them, a green ...

7 years ago (2013-12-06 20:19:40 UTC) #3

sdefresne

On 2013/12/06 20:19:40, Mark Mentovai wrote: > Sorry for the delay on all of these. ...

7 years ago (2013-12-09 14:41:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r1810 (presubmit successful).

Expand Messages | Collapse Messages