Add support for resetting pan and tilt on Logitech webcams.

Add support for resetting pan and tilt on Logitech webcams.

BUG=447440
Committed: https://crrev.com/8ac831dc77372d713059ff92e45bfd392c8b68cc
Cr-Commit-Position: refs/heads/master@{#311454}

[Zachary Kuznia, 2015-01-09 02:02:17]

zork@chromium.org changed reviewers:
+ tommi@chromium.org

[Zachary Kuznia, 2015-01-09 02:02:18]

Please take a look.

[tommi (sloooow) - chröme, 2015-01-13 16:37:40]

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
File extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc
(right):

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:26: /*
use // type comments

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:45: const
uvc_menu_info kLogitechCmdMenu[3] = {
since you're using sizeof to derive this size, do you need to specify it here? 
I.e. is it OK to do:
const uvc_menu_info kLogitechCmdMenu[] = {
...

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:58:
const_cast<uvc_menu_info*>(kLogitechCmdMenu),
nit: &kLogitechCmdMenu[0]

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:59:
sizeof(kLogitechCmdMenu)/sizeof(struct uvc_menu_info),
arraysize()

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:99: if (res
< 0) {
nit:

return res < 0 || errno == EEXIST;

[Zachary Kuznia, 2015-01-13 20:54:59]

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
File extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc
(right):

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:26: /*
On 2015/01/13 16:37:39, tommi wrote:
> use // type comments

Done.

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:45: const
uvc_menu_info kLogitechCmdMenu[3] = {
On 2015/01/13 16:37:39, tommi wrote:
> since you're using sizeof to derive this size, do you need to specify it here?

> I.e. is it OK to do:
> const uvc_menu_info kLogitechCmdMenu[] = {
> ...

Done.

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:58:
const_cast<uvc_menu_info*>(kLogitechCmdMenu),
On 2015/01/13 16:37:39, tommi wrote:
> nit: &kLogitechCmdMenu[0]

Done.

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:59:
sizeof(kLogitechCmdMenu)/sizeof(struct uvc_menu_info),
On 2015/01/13 16:37:40, tommi wrote:
> arraysize()

Done.

https://codereview.chromium.org/830673005/diff/1/extensions/browser/api/webca...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:99: if (res
< 0) {
On 2015/01/13 16:37:40, tommi wrote:
> nit:
> 
> return res < 0 || errno == EEXIST;

Done.

[tommi (sloooow) - chröme, 2015-01-13 21:07:36]

https://codereview.chromium.org/830673005/diff/20001/extensions/browser/api/w...
File extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc
(right):

https://codereview.chromium.org/830673005/diff/20001/extensions/browser/api/w...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:97: // If
mapping is successful or it's already mapped, this is a Logitec Camera.
nit: Logitech camera.
(missing 'h' and caps)

https://codereview.chromium.org/830673005/diff/20001/extensions/browser/api/w...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:98: return
res < 0 || errno == EEXIST;
sorry, my bad.  This should be:

return res >= 0 || errno == EEXIST;

[Zachary Kuznia, 2015-01-13 22:22:52]

https://codereview.chromium.org/830673005/diff/20001/extensions/browser/api/w...
File extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc
(right):

https://codereview.chromium.org/830673005/diff/20001/extensions/browser/api/w...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:97: // If
mapping is successful or it's already mapped, this is a Logitec Camera.
On 2015/01/13 21:07:35, tommi wrote:
> nit: Logitech camera.
> (missing 'h' and caps)

Done.

https://codereview.chromium.org/830673005/diff/20001/extensions/browser/api/w...
extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc:98: return
res < 0 || errno == EEXIST;
On 2015/01/13 21:07:36, tommi wrote:
> sorry, my bad.  This should be:
> 
> return res >= 0 || errno == EEXIST;

Done and retested.  My test app was calling reset twice, so I missed the
original (res < 0) test failing.

[tommi (sloooow) - chröme, 2015-01-14 10:41:17]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2015-01-14 10:41:17]

lgtm

[commit-bot: I haz the power, 2015-01-14 10:42:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/830673005/40001

[commit-bot: I haz the power, 2015-01-14 11:38:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-14 11:39:31]

Patchset 3 (id:??) landed as
https://crrev.com/8ac831dc77372d713059ff92e45bfd392c8b68cc
Cr-Commit-Position: refs/heads/master@{#311454}