Issue 830553002: Merge: Create pdfium_unittests binary. [XFA]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 830553002: Merge: Create pdfium_unittests binary. [XFA] (Closed)

Created:
5 years, 11 months ago by Tom Sepez

Modified:
5 years, 11 months ago

Reviewers:

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge: Create pdfium_unittests binary. [XFA] Original CL at https://codereview.chromium.org/831653002/ TBR=palmer@chromium.org, brucedawson@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bb1405dda43fd4b605fd9c2808dc0ead87f54ccc

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -0 lines)			Patch
M	BUILD.gn	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	core/src/fxcrt/fx_basic_bstring_unittest.cpp	View	1 chunk	+42 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Committed patchset #1 (id:1) manually as bb1405dda43fd4b605fd9c2808dc0ead87f54ccc (presubmit successful).

5 years, 11 months ago (2014-12-29 22:02:21 UTC) #2

brucedawson

5 years, 11 months ago (2015-01-02 23:51:03 UTC) #3

Message was sent while issue was closed.

This change has left the XFA branch in a bad state. I'm getting these errors
when I try to build:

D:\src\pdfium>python build\gyp_pdfium
Updating projects from gyp files...
gyp: D:\testing\gtest.gyp not found (cwd: D:\src\pdfium)
gyp: D:\base\base.gyp not found (cwd: D:\src\pdfium)

Expand Messages | Collapse Messages