Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: runtime/bin/fdutils_macos.cc

Issue 83053002: Remove unneded debug printing from FDUtils. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/fdutils_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/fdutils_macos.cc
diff --git a/runtime/bin/fdutils_macos.cc b/runtime/bin/fdutils_macos.cc
index 65f283257c3e2c935c21f1c15c2261af7f00d1c7..bbc442df978660cff04bd2a55810cc5ff4ef3160 100644
--- a/runtime/bin/fdutils_macos.cc
+++ b/runtime/bin/fdutils_macos.cc
@@ -20,12 +20,10 @@ bool FDUtils::SetCloseOnExec(intptr_t fd) {
intptr_t status;
status = TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD));
if (status < 0) {
- perror("fcntl F_GETFD failed");
return false;
}
status |= FD_CLOEXEC;
if (TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD, status)) < 0) {
- perror("fcntl F_SETFD failed");
return false;
}
return true;
@@ -36,12 +34,10 @@ static bool SetBlockingHelper(intptr_t fd, bool blocking) {
intptr_t status;
status = TEMP_FAILURE_RETRY(fcntl(fd, F_GETFL));
if (status < 0) {
- perror("fcntl F_GETFL failed");
return false;
}
status = blocking ? (status & ~O_NONBLOCK) : (status | O_NONBLOCK);
if (TEMP_FAILURE_RETRY(fcntl(fd, F_SETFL, status)) < 0) {
- perror("fcntl F_SETFL failed");
return false;
}
return true;
@@ -62,7 +58,6 @@ bool FDUtils::IsBlocking(intptr_t fd, bool* is_blocking) {
intptr_t status;
status = TEMP_FAILURE_RETRY(fcntl(fd, F_GETFL));
if (status < 0) {
- perror("fcntl F_GETFL failed");
return false;
}
*is_blocking = (status & O_NONBLOCK) == 0;
@@ -74,7 +69,6 @@ intptr_t FDUtils::AvailableBytes(intptr_t fd) {
int available; // ioctl for FIONREAD expects an 'int*' argument.
int result = TEMP_FAILURE_RETRY(ioctl(fd, FIONREAD, &available));
if (result < 0) {
- perror("ioctl FIONREAD failed");
return result;
}
#ifdef DEBUG
« no previous file with comments | « runtime/bin/fdutils_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698