Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1565)

Unified Diff: components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_ui_manager.h

Issue 830503004: Data Reduction Proxy blocking page and resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@interstitalStep1
Patch Set: Test resources fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_ui_manager.h
diff --git a/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_ui_manager.h b/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_ui_manager.h
index cb3ca8d82d1256a127a666132295a8a098733234..b7bda25ae70fec606615c7c763e5d471776b221e 100644
--- a/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_ui_manager.h
+++ b/components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_ui_manager.h
@@ -5,6 +5,7 @@
#ifndef COMPONENTS_DATA_REDUCTION_PROXY_CONTENT_BROWSER_DATA_REDUCTION_PROXY_DEBUG_UI_MANAGER_H_
#define COMPONENTS_DATA_REDUCTION_PROXY_CONTENT_BROWSER_DATA_REDUCTION_PROXY_DEBUG_UI_MANAGER_H_
+#include <string>
#include <vector>
#include "base/callback.h"
@@ -46,7 +47,8 @@ class DataReductionProxyDebugUIManager
// not be shown for five minutes.
DataReductionProxyDebugUIManager(
const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner,
- const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner);
+ const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
+ const std::string& app_locale);
bengr 2015/02/05 01:30:09 Can local be empty? Say so and say how it will be
megjablon 2015/02/13 01:48:08 Done.
// Using |resource.render_process_host_id| and |resource.render_view_id|
// checks if WebContents exists for the RenderViewHost retreived from these
@@ -58,9 +60,12 @@ class DataReductionProxyDebugUIManager
// redirects, |url| is the last url in the chain.
virtual void DisplayBlockingPage(const BypassResource& resource);
+ // Virtual for testing purposes.
+ virtual void ShowBlockingPage(const BypassResource& resource);
+
// The blocking page on the UI thread has completed.
void OnBlockingPageDone(
- const BypassResource& resource, bool proceed);
+ const std::vector<BypassResource>& resources, bool proceed);
private:
// Ref counted classes have private destructors to avoid any code deleting the
@@ -81,6 +86,8 @@ class DataReductionProxyDebugUIManager
// A task runner to post OnBlockingPageDone to the IO thread.
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
+ const std::string& app_locale_;
+
DISALLOW_COPY_AND_ASSIGN(DataReductionProxyDebugUIManager);
};

Powered by Google App Engine
This is Rietveld 408576698