components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_manager.h - Issue 830503004: Data Reduction Proxy blocking page and resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_manager.h

Issue 830503004: Data Reduction Proxy blocking page and resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@interstitalStep1

Patch Set: Rebase and crash fixes Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/content/browser/BUILD.gn ('K') | « components/data_reduction_proxy/content/browser/data_reduction_proxy_blocking_page_unittest.cc ('k') | components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_manager.h

diff --git a/components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_manager.h b/components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_manager.h

index 58c2a43674a1416a450c5409fb49e14e4918e9f0..6e7fd0f83a1bd1f8bc194d6903b557b2a313ccd8 100644

--- a/components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_manager.h

+++ b/components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_manager.h

@@ -56,8 +56,12 @@ class DataReductionProxyUIManager

// first one (the root of the chain). Otherwise, |original_url| = |url|.

virtual void DisplayBlockingPage(const BypassResource& resource);

+ // Virtual for testing purposes.

+ virtual void ShowBlockingPage(const BypassResource& resource);

// The blocking page on the UI thread has completed.

- void OnBlockingPageDone(const BypassResource& resource, bool proceed);

+ void OnBlockingPageDone(const std::vector<BypassResource>& resources,

+ bool proceed);

private:

// Ref counted classes have private destructors to avoid any code deleting the