Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 830503003: Move shortcuts_database.{cc,h} to //chrome/browser/autocomplete (Closed)

Created:
5 years, 11 months ago by sdefresne
Modified:
5 years, 11 months ago
Reviewers:
Peter Kasting, sky
CC:
browser-components-watch_chromium.org, chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@history-file-moves
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move shortcuts_database.{cc,h} to //chrome/browser/autocomplete The sole client of ShortcutsDatabase is ShortcutsBackend and the implementation of ShortcutsDatabase does not depends on //c/b/history so it makes more sense to put this code in //c/b/autocomplete. All files were moved using tools/git/move_source_files.py and then the build system files (gyp and gn) were manually editted. BUG=370850, 371538 Committed: https://crrev.com/a3b96025c9fea20795c11664978fc2bca98cd651 Cr-Commit-Position: refs/heads/master@{#309920}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -734 lines) Patch
M chrome/browser/autocomplete/shortcuts_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/autocomplete/shortcuts_database.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/autocomplete/shortcuts_database.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/autocomplete/shortcuts_database_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
D chrome/browser/history/shortcuts_database.h View 1 chunk +0 lines, -139 lines 0 comments Download
D chrome/browser/history/shortcuts_database.cc View 1 chunk +0 lines, -281 lines 0 comments Download
D chrome/browser/history/shortcuts_database_unittest.cc View 1 chunk +0 lines, -303 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
sky: can you review since you are OWNERS of both //chrome/browser/history and //chrome/browser/autocomplete. I don't ...
5 years, 11 months ago (2014-12-29 22:41:11 UTC) #2
tfarina
+Peter for autocomplete review!
5 years, 11 months ago (2014-12-29 22:59:38 UTC) #4
Peter Kasting
Originally, both ShortcutsBackend and ShortcutsDatabase were in c/b/history/, I think because other code in history ...
5 years, 11 months ago (2014-12-30 05:20:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830503003/40001
5 years, 11 months ago (2015-01-05 17:45:45 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-05 17:59:27 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 18:00:37 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a3b96025c9fea20795c11664978fc2bca98cd651
Cr-Commit-Position: refs/heads/master@{#309920}

Powered by Google App Engine
This is Rietveld 408576698