Add ChromiumOS Trybot support.

Add ChromiumOS Trybot support.

Adds a modified Git poller ported over by Brad Nelson to use until BB8 transition is fully complete, 
and the new BB8 git poller has been tested.

BUG=chromium-os:21095, chromium-os:21906, chromium-os:21094
TEST=Ran buildbot master and slave locally.

[rcui1, 2011-10-14 22:27:08]

Supporting CL - https://chromereviews.googleplex.com/3598018/

[rcui1, 2011-10-14 23:09:28]

http://codereview.chromium.org/8305010/diff/1/scripts/master/try_job_base.py
File scripts/master/try_job_base.py (right):

http://codereview.chromium.org/8305010/diff/1/scripts/master/try_job_base.py#...
scripts/master/try_job_base.py:58: options.setdefault('clobber', None)
Default clobber to None (the old behavior) since ChromeOSFactory relies on this.

[M-A Ruel, 2011-10-14 23:21:20]

lgtm

http://codereview.chromium.org/8305010/diff/1/masters/master.tryserver.chromi...
File masters/master.tryserver.chromiumos/master.cfg (right):

http://codereview.chromium.org/8305010/diff/1/masters/master.tryserver.chromi...
masters/master.tryserver.chromiumos/master.cfg:46:
builder_mapping=cros_builder_mapping.CONFIG_NAME_DICT)
Use spaces

http://codereview.chromium.org/8305010/diff/1/masters/master.tryserver.chromi...
masters/master.tryserver.chromiumos/master.cfg:70: 
Use 2 lines between file level symbols.

http://codereview.chromium.org/8305010/diff/1/masters/master.tryserver.chromi...
masters/master.tryserver.chromiumos/master.cfg:103: c['builders'] = BUILDERS
You could set c['builders'] = [] around line 63 and use it at line 80 so you
wouldn't need it here. I'm not sure it's useful to alias it. But I don't mind
much.

[rcui1, 2011-10-14 23:52:07]

http://codereview.chromium.org/8305010/diff/1/masters/master.tryserver.chromi...
File masters/master.tryserver.chromiumos/master.cfg (right):

http://codereview.chromium.org/8305010/diff/1/masters/master.tryserver.chromi...
masters/master.tryserver.chromiumos/master.cfg:46:
builder_mapping=cros_builder_mapping.CONFIG_NAME_DICT)
On 2011/10/14 23:21:20, Marc-Antoine Ruel wrote:
> Use spaces

Done.

http://codereview.chromium.org/8305010/diff/1/masters/master.tryserver.chromi...
masters/master.tryserver.chromiumos/master.cfg:70: 
On 2011/10/14 23:21:20, Marc-Antoine Ruel wrote:
> Use 2 lines between file level symbols.

Done.

http://codereview.chromium.org/8305010/diff/1/masters/master.tryserver.chromi...
masters/master.tryserver.chromiumos/master.cfg:103: c['builders'] = BUILDERS
On 2011/10/14 23:21:20, Marc-Antoine Ruel wrote:
> You could set c['builders'] = [] around line 63 and use it at line 80 so you
> wouldn't need it here. I'm not sure it's useful to alias it. But I don't mind
> much.

Done.

[commit-bot: I haz the power, 2011-10-14 23:52:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rcui@google.com/8305010/6001

[commit-bot: I haz the power, 2011-10-14 23:52:51]

Can't apply patch for file build/masters/master.tryserver.chromiumos/master.cfg.
While running patch -p0 --forward --force;
A         build/masters/master.tryserver.chromiumos
patching file build/masters/master.tryserver.chromiumos/master.cfg
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
build/masters/master.tryserver.chromiumos/master.cfg.rej

[commit-bot: I haz the power, 2011-10-15 00:44:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rcui@google.com/8305010/7002

[commit-bot: I haz the power, 2011-10-15 00:44:45]

Can't apply patch for file build/masters/master.tryserver.chromiumos/master.cfg.
While running patch -p0 --forward --force;
patching file build/masters/master.tryserver.chromiumos/master.cfg
Hunk #1 FAILED at 5.
Hunk #2 FAILED at 203.
Hunk #3 FAILED at 258.
Hunk #4 FAILED at 288.
Hunk #5 FAILED at 301.
5 out of 5 hunks FAILED -- saving rejects to file
build/masters/master.tryserver.chromiumos/master.cfg.rej

[Peter Mayo, 2011-10-15 00:57:42]

http://codereview.chromium.org/8305010/diff/8001/scripts/master/factory/chrom...
File scripts/master/factory/chromeos_factory.py (right):

http://codereview.chromium.org/8305010/diff/8001/scripts/master/factory/chrom...
scripts/master/factory/chromeos_factory.py:259:
cbuild_cmd.append(WithProperties("--gerrit-patches='%(gerrit_patches)s'"))
I suggest guarding this with if self.trybot

I don't think we want --gerrit-patches=  being tacked on to the regular bots.

[cmp, 2011-10-16 23:19:37]

Hi Ryan, This change broke the presubmit tests for trunk/build/ and a full
master.DEPS checkout.  There are two problems:
1. Our pylint checks on changes to files in scripts/master/ catch many errors in
this file (because Buildbot 0.8.2 doesn't follow these rules)
2. ChromiumOSTryServer is not defined in build_internal (which causes
tryserver.chromiumos to fail to start in the default internal config)

So we can't keep this change in as-is: until these problems are fixed everyone
else will be forcing past the presubmit errors, not catching errors that may be
due to their change.  The right thing to do is to fix this asap or revert it. 
I'll revert it in a bit (with no prejudice) if no one's around to fix it.

I'm positive that what happened here was that you committed locally after fixing
the merge conflicts the commit queue detected instead of re-uploading your CL
and re-using the CQ.  Just for a sanity check, can you verify the presubmit
tests run in your local environment?  Thanks.

[cmp, 2011-10-16 23:58:15]

On 2011/10/16 23:19:37, cmp wrote:
> 1. Our pylint checks on changes to files in scripts/master/
> catch many errors in this file (because Buildbot 0.8.2 doesn't
> follow these rules)

nsylvain landed a whitelist fix for the pylint errors.  At least the presubmit
errors should go away.

> 2. ChromiumOSTryServer is not defined in build_internal (which 
> causes tryserver.chromiumos to fail to start in the default
> internal config)

This was only an issue for me, so never a real issue, my bad.  I wasn't running
with a fully-up-to-date checkout.  That's fixed on my end now.

[M-A Ruel, 2011-10-17 01:44:04]

That's what happen when I do a code review in a hurry. :(

Please leave third_party code in third_party.

[rcui1, 2011-10-17 18:28:10]

Sorry about this guys ... when I was trying to submit I saw there were presubmit
check failures from other files (that I did not touch) so I thought people were
forcing through the submit.  I should have verified with someone before the
checkin.  Sorry for the trouble, thanks for the reversion Chase.

[rcui1, 2011-10-17 19:47:47]

So just for the record, Peter's comments were addressed in 
http://codereview.chromium.org/8304016/, and the addition of ChromiumOSTryServer
to build_internal is in CL
https://chromereviews.googleplex.com/3598018.