Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: chrome/browser/history/history_service.cc

Issue 830483005: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/history/history_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.cc
diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc
index f010de61e0f7777676666378dd64b133798be363..a91bc00fe6a27cd1f533eed8cac383a1db030606 100644
--- a/chrome/browser/history/history_service.cc
+++ b/chrome/browser/history/history_service.cc
@@ -197,6 +197,12 @@ class HistoryService::BackendDelegate : public HistoryBackend::Delegate {
history_service_, row, keyword_id, term));
}
+ void NotifyKeywordSearchTermDeleted(history::URLID url_id) override {
+ service_task_runner_->PostTask(
+ FROM_HERE, base::Bind(&HistoryService::NotifyKeywordSearchTermDeleted,
+ history_service_, url_id));
+ }
+
void BroadcastNotifications(
int type,
scoped_ptr<history::HistoryDetails> details) override {
@@ -1297,6 +1303,12 @@ void HistoryService::NotifyKeywordSearchTermUpdated(
OnKeywordSearchTermUpdated(this, row, keyword_id, term));
}
+void HistoryService::NotifyKeywordSearchTermDeleted(history::URLID url_id) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ FOR_EACH_OBSERVER(history::HistoryServiceObserver, observers_,
+ OnKeywordSearchTermDeleted(this, url_id));
+}
+
scoped_ptr<base::CallbackList<void(const std::set<GURL>&)>::Subscription>
HistoryService::AddFaviconChangedCallback(
const HistoryService::OnFaviconChangedCallback& callback) {
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/history/history_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698