chrome/browser/android/provider/chrome_browser_provider.h - Issue 830483005: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_DELETED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/provider/chrome_browser_provider.h

Issue 830483005: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/provider/chrome_browser_provider.h

diff --git a/chrome/browser/android/provider/chrome_browser_provider.h b/chrome/browser/android/provider/chrome_browser_provider.h

index cc2f4b75a927f2ebb63a3b3659e35df7c43073e9..630e17aafc5b02e92e2f33c0bec125f5ca45c07c 100644

--- a/chrome/browser/android/provider/chrome_browser_provider.h

+++ b/chrome/browser/android/provider/chrome_browser_provider.h

@@ -195,6 +195,8 @@ class ChromeBrowserProvider : public bookmarks::BaseBookmarkModelObserver,

const history::URLRow& row,

history::KeywordID keyword_id,

const base::string16& term) override;

+ void OnKeywordSearchTermDeleted(HistoryService* history_service,

+ history::URLID url_id) override{};

newt (away) 2015/01/16 18:58:03 space before {

sdefresne 2015/01/17 18:23:23 Nit: no ; after the {} too, and could you not inli

Abhishek 2015/01/19 06:13:01 Done.

// Override content::NotificationObserver.

virtual void Observe(int type,

« no previous file with comments | « no previous file | chrome/browser/chrome_notification_types.h » ('j') | no next file with comments »