chrome/browser/history/history_service.h - Issue 830483005: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_DELETED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_service.h

Issue 830483005: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated provider Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/history_notifications.cc ('k') | chrome/browser/history/history_service.cc » ('j') | components/history/core/browser/history_service_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_service.h

diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h

index fc9dd80426c91a700ee5bc9e82b9994aed6090ab..1a34e6431b4645890bb9d344c437df982cd724fd 100644

--- a/chrome/browser/history/history_service.h

+++ b/chrome/browser/history/history_service.h

@@ -623,6 +623,10 @@ class HistoryService : public content::NotificationObserver,

history::KeywordID keyword_id,

const base::string16& term);

+ // Notify all HistoryServiceObservers registered that keyword search term is

+ // deleted. |url_id| id of the url row.

sdefresne 2015/01/16 06:56:00 Style: comment must be correct english sentences

Abhishek 2015/01/16 07:43:48 Thanks for the correction! I was thinking it, like

+ void NotifyKeywordSearchTermDeleted(history::URLID url_id);

// Favicon -------------------------------------------------------------------

// These favicon methods are exposed to the FaviconService. Instead of calling