Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chrome/browser/history/history_backend.h

Issue 830483005: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 // be forwarded to the HistoryServiceObservers in the correct thread. 143 // be forwarded to the HistoryServiceObservers in the correct thread.
144 virtual void NotifyURLsModified(const URLRows& changed_urls) = 0; 144 virtual void NotifyURLsModified(const URLRows& changed_urls) = 0;
145 145
146 // Notify HistoryService that some keyword has been searched using omnibox. 146 // Notify HistoryService that some keyword has been searched using omnibox.
147 // The event will be forwarded to the HistoryServiceObservers in the correct 147 // The event will be forwarded to the HistoryServiceObservers in the correct
148 // thread. 148 // thread.
149 virtual void NotifyKeywordSearchTermUpdated(const URLRow& row, 149 virtual void NotifyKeywordSearchTermUpdated(const URLRow& row,
150 KeywordID keyword_id, 150 KeywordID keyword_id,
151 const base::string16& term) = 0; 151 const base::string16& term) = 0;
152 152
153 // Notify HistoryService that keyword search term has been deleted.
154 // The event will be forwarded to the HistoryServiceObservers in the correct
155 // thread.
156 virtual void NotifyKeywordSearchTermDeleted(URLID url_id) = 0;
157
153 // Broadcasts the specified notification to the notification service. 158 // Broadcasts the specified notification to the notification service.
154 // This is implemented here because notifications must only be sent from 159 // This is implemented here because notifications must only be sent from
155 // the main thread. This is the only method that doesn't identify the 160 // the main thread. This is the only method that doesn't identify the
156 // caller because notifications must always be sent. 161 // caller because notifications must always be sent.
157 virtual void BroadcastNotifications(int type, 162 virtual void BroadcastNotifications(int type,
158 scoped_ptr<HistoryDetails> details) = 0; 163 scoped_ptr<HistoryDetails> details) = 0;
159 164
160 // Invoked when the backend has finished loading the db. 165 // Invoked when the backend has finished loading the db.
161 virtual void DBLoaded() = 0; 166 virtual void DBLoaded() = 0;
162 }; 167 };
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
917 922
918 // List of observers 923 // List of observers
919 ObserverList<HistoryBackendObserver> observers_; 924 ObserverList<HistoryBackendObserver> observers_;
920 925
921 DISALLOW_COPY_AND_ASSIGN(HistoryBackend); 926 DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
922 }; 927 };
923 928
924 } // namespace history 929 } // namespace history
925 930
926 #endif // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 931 #endif // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
OLDNEW
« no previous file with comments | « chrome/browser/history/android/android_provider_backend_unittest.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698