Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 830483005: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/chrome_notification_types.h ('k') | chrome/browser/history/history_backend.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/android/android_provider_backend.h" 5 #include "chrome/browser/history/android/android_provider_backend.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 void NotifyURLVisited(ui::PageTransition, 80 void NotifyURLVisited(ui::PageTransition,
81 const history::URLRow& row, 81 const history::URLRow& row,
82 const history::RedirectList& redirects, 82 const history::RedirectList& redirects,
83 base::Time visit_time) override {} 83 base::Time visit_time) override {}
84 void NotifyURLsModified(const history::URLRows& rows) override { 84 void NotifyURLsModified(const history::URLRows& rows) override {
85 modified_details_.reset(new history::URLRows(rows)); 85 modified_details_.reset(new history::URLRows(rows));
86 } 86 }
87 void NotifyKeywordSearchTermUpdated(const URLRow& row, 87 void NotifyKeywordSearchTermUpdated(const URLRow& row,
88 KeywordID keyword_id, 88 KeywordID keyword_id,
89 const base::string16& term) override {} 89 const base::string16& term) override {}
90 void NotifyKeywordSearchTermDeleted(URLID url_id) override {}
90 void BroadcastNotifications( 91 void BroadcastNotifications(
91 int type, 92 int type,
92 scoped_ptr<HistoryDetails> details) override { 93 scoped_ptr<HistoryDetails> details) override {
93 DCHECK_EQ(type, chrome::NOTIFICATION_HISTORY_URLS_DELETED); 94 DCHECK_EQ(type, chrome::NOTIFICATION_HISTORY_URLS_DELETED);
94 scoped_ptr<URLsDeletedDetails> urls_deleted_details( 95 scoped_ptr<URLsDeletedDetails> urls_deleted_details(
95 static_cast<URLsDeletedDetails*>(details.release())); 96 static_cast<URLsDeletedDetails*>(details.release()));
96 deleted_details_.reset(new history::URLRows(urls_deleted_details->rows)); 97 deleted_details_.reset(new history::URLRows(urls_deleted_details->rows));
97 } 98 }
98 void DBLoaded() override {} 99 void DBLoaded() override {}
99 100
(...skipping 2045 matching lines...) Expand 10 before | Expand all | Expand 10 after
2145 update_args, &update_count)); 2146 update_args, &update_count));
2146 // Verify notifications. 2147 // Verify notifications.
2147 EXPECT_FALSE(notifier_.deleted_details()); 2148 EXPECT_FALSE(notifier_.deleted_details());
2148 ASSERT_TRUE(notifier_.modified_details()); 2149 ASSERT_TRUE(notifier_.modified_details());
2149 ASSERT_EQ(1u, notifier_.modified_details()->size()); 2150 ASSERT_EQ(1u, notifier_.modified_details()->size());
2150 // No favicon will be updated as thumbnail database is missing. 2151 // No favicon will be updated as thumbnail database is missing.
2151 EXPECT_FALSE(notifier_.favicon_changed()); 2152 EXPECT_FALSE(notifier_.favicon_changed());
2152 } 2153 }
2153 2154
2154 } // namespace history 2155 } // namespace history
OLDNEW
« no previous file with comments | « chrome/browser/chrome_notification_types.h ('k') | chrome/browser/history/history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698