Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: chrome/browser/android/provider/chrome_browser_provider.cc

Issue 830483005: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/provider/chrome_browser_provider.h" 5 #include "chrome/browser/android/provider/chrome_browser_provider.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <list> 8 #include <list>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 1618 matching lines...) Expand 10 before | Expand all | Expand 10 after
1629 const history::URLRow& row, 1629 const history::URLRow& row,
1630 history::KeywordID keyword_id, 1630 history::KeywordID keyword_id,
1631 const base::string16& term) { 1631 const base::string16& term) {
1632 JNIEnv* env = AttachCurrentThread(); 1632 JNIEnv* env = AttachCurrentThread();
1633 ScopedJavaLocalRef<jobject> obj = weak_java_provider_.get(env); 1633 ScopedJavaLocalRef<jobject> obj = weak_java_provider_.get(env);
1634 if (obj.is_null()) 1634 if (obj.is_null())
1635 return; 1635 return;
1636 Java_ChromeBrowserProvider_onSearchTermChanged(env, obj.obj()); 1636 Java_ChromeBrowserProvider_onSearchTermChanged(env, obj.obj());
1637 } 1637 }
1638 1638
1639 void ChromeBrowserProvider::OnKeywordSearchTermDeleted(
1640 HistoryService* history_service,
1641 history::URLID url_id) {
1642 OnHistoryChanged();
sdefresne 2015/01/15 17:53:55 Remove, ChromeBrowserProvider was not calling OnHi
Abhishek 2015/01/16 05:55:58 Done.
1643 }
1644
1639 void ChromeBrowserProvider::Observe( 1645 void ChromeBrowserProvider::Observe(
1640 int type, 1646 int type,
1641 const content::NotificationSource& source, 1647 const content::NotificationSource& source,
1642 const content::NotificationDetails& details) { 1648 const content::NotificationDetails& details) {
1643 DCHECK_EQ(type, chrome::NOTIFICATION_HISTORY_URLS_DELETED);
sdefresne 2015/01/15 17:53:55 Do not remove those lines.
Abhishek 2015/01/16 05:55:58 Done.
1644 OnHistoryChanged();
1645 } 1649 }
OLDNEW
« no previous file with comments | « chrome/browser/android/provider/chrome_browser_provider.h ('k') | chrome/browser/chrome_notification_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698