Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

Issue 830463003: dart2js: collect static-non-final fields in the task. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
diff --git a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
index 01c596381a30075f99227517986acd5a992b4ca4..a027ced641dbe594cc11f9e4fbb62976e4dc41cd 100644
--- a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
+++ b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
@@ -27,6 +27,8 @@ class CodeEmitterTask extends CompilerTask {
new Map<OutputUnit, List<ConstantValue>>();
final Map<OutputUnit, List<Element>> outputStaticLists =
new Map<OutputUnit, List<Element>>();
+ final Map<OutputUnit, List<VariableElement>> outputStaticNonFinalFieldLists =
+ new Map<OutputUnit, List<VariableElement>>();
final Map<OutputUnit, Set<LibraryElement>> outputLibraryLists =
new Map<OutputUnit, Set<LibraryElement>>();
@@ -360,10 +362,22 @@ class CodeEmitterTask extends CompilerTask {
backend.generatedCode.keys.where(isStaticFunction);
for (Element element in Elements.sortedByPosition(elements)) {
- outputStaticLists.putIfAbsent(
+ List<Element> list = outputStaticLists.putIfAbsent(
compiler.deferredLoadTask.outputUnitForElement(element),
- () => new List<Element>())
- .add(element);
+ () => new List<Element>());
+ list.add(element);
+ }
+ }
+
+ void computeNeededStaticNonFinalFields() {
+ JavaScriptConstantCompiler handler = backend.constants;
+ Iterable<VariableElement> staticNonFinalFields =
+ handler.getStaticNonFinalFieldsForEmission();
+ for (Element element in Elements.sortedByPosition(staticNonFinalFields)) {
+ List<VariableElement> list = outputStaticNonFinalFieldLists.putIfAbsent(
+ compiler.deferredLoadTask.outputUnitForElement(element),
+ () => new List<VariableElement>());
+ list.add(element);
}
}
@@ -387,6 +401,7 @@ class CodeEmitterTask extends CompilerTask {
computeNeededDeclarations();
computeNeededConstants();
computeNeededStatics();
+ computeNeededStaticNonFinalFields();
computeNeededLibraries();
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698