Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 830453004: Win-Clang update script: update paths for 3.7.0 (Closed)

Created:
5 years, 11 months ago by Timur Iskhodzhanov
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Win-Clang update script: update paths for 3.7.0 BUG=345874 NOTRY=true TBR=hans@chromium.org Committed: https://crrev.com/365631116a8a7943a2a1c0dd20ab2881aedebad2 Cr-Commit-Position: refs/heads/master@{#311878}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 1 comment Download
M tools/clang/scripts/update.py View 3 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-16 12:14:37 UTC) #2
Timur Iskhodzhanov
hans@: TBR inferno@: this might temporarily break CF, I'll try to make an ASan/Win roll ...
5 years, 11 months ago (2015-01-16 12:17:04 UTC) #3
Timur Iskhodzhanov
this time inferno@ for real > inferno@: this might temporarily break CF, > I'll try ...
5 years, 11 months ago (2015-01-16 12:17:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830453004/1
5 years, 11 months ago (2015-01-16 12:18:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 12:19:12 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/365631116a8a7943a2a1c0dd20ab2881aedebad2 Cr-Commit-Position: refs/heads/master@{#311878}
5 years, 11 months ago (2015-01-16 12:20:21 UTC) #8
Timur Iskhodzhanov
Hans, FYI https://codereview.chromium.org/830453004/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/830453004/diff/1/build/common.gypi#newcode5547 build/common.gypi:5547: '<(DEPTH)/<(make_clang_dir)/lib/clang/3.7.0/lib/windows', For the record, turns out I've ...
5 years, 10 months ago (2015-01-27 13:27:55 UTC) #9
hans
5 years, 10 months ago (2015-01-27 17:13:11 UTC) #10
Message was sent while issue was closed.
On 2015/01/27 13:27:55, Timur Iskhodzhanov wrote:
> Hans, FYI
> 
> https://codereview.chromium.org/830453004/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
> https://codereview.chromium.org/830453004/diff/1/build/common.gypi#newcode5547
> build/common.gypi:5547:
> '<(DEPTH)/<(make_clang_dir)/lib/clang/3.7.0/lib/windows',
> For the record, turns out I've forgotten to update a similar path in
> build/win/asan.gyp
> Should be fixed by https://codereview.chromium.org/879863003/

Thanks.

> 
> We should do that again when the path changes again...

Or I should fix my TODO and make the build file not depend on the version
number. We'll see which one happens first :-)

Powered by Google App Engine
This is Rietveld 408576698