pdf/pdf_engine.h - Issue 830433002: Navigation to relative fragments does not work correctly for OOP pdf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdf_engine.h

Issue 830433002: Navigation to relative fragments does not work correctly for OOP pdf. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pdf/pdf_engine.h

diff --git a/pdf/pdf_engine.h b/pdf/pdf_engine.h

index b81494f02fa8c287ce169871e7844422d0f0cd8a..49f0bee99cf2c21bc199f0cb180c311a6176cc6e 100644

--- a/pdf/pdf_engine.h

+++ b/pdf/pdf_engine.h

@@ -27,6 +27,7 @@

namespace pp {

class InputEvent;

+class VarDictionary;

}

const uint32 kBackgroundColor = 0xFFCCCCCC;

@@ -260,6 +261,10 @@ class PDFEngine {

virtual void SetScrollPosition(const pp::Point& position) = 0;

virtual bool IsProgressiveLoad() = 0;

+ virtual unsigned long GetNameDestCount() = 0;

+ virtual void GetNameDests(std::vector<std::string>* name_dest) = 0;

+ virtual void GetAllNameDests(pp::VarDictionary* named_destinations) = 0;

raymes 2015/01/13 01:59:31 nit: Let's make it verbose: GetAllNamedDestination

Deepak 2015/01/13 08:29:07 Done.

};

// Interface for exports that wrap the PDF engine.

« pdf/out_of_process_instance.cc ('K') | « pdf/out_of_process_instance.cc ('k') | pdf/pdfium/pdfium_engine.h » ('j') | pdf/pdfium/pdfium_engine.cc » ('J')