pdf/pdfium/pdfium_engine.h - Issue 830433002: Navigation to relative fragments does not work correctly for OOP pdf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdfium/pdfium_engine.h

Issue 830433002: Navigation to relative fragments does not work correctly for OOP pdf. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes after taking all nameddest at load time. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pdf/pdfium/pdfium_engine.h

diff --git a/pdf/pdfium/pdfium_engine.h b/pdf/pdfium/pdfium_engine.h

index 960c5f2f7f3ae80c7badeccdd3ff729e3f071271..6bf5cb7e2630c4dee5d654a0fe20cbc952a300c0 100644

--- a/pdf/pdfium/pdfium_engine.h

+++ b/pdf/pdfium/pdfium_engine.h

@@ -104,6 +104,9 @@ class PDFiumEngine : public PDFEngine,

virtual void OnNewDataAvailable();

virtual void OnDocumentComplete();

+ virtual unsigned long GetNameDestCount();

+ virtual void GetNameDests(std::vector<std::string>* name_dest);

void UnsupportedFeature(int type);

std::string current_find_text() const { return current_find_text_; }

« pdf/pdf_engine.h ('K') | « pdf/pdf_engine.h ('k') | pdf/pdfium/pdfium_engine.cc » ('j') | no next file with comments »