Navigation to relative fragments does not work correctly for OOP pdf.

pdf/out_of_process_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/out_of_process_instance.h"
 
 #include <algorithm>  // for min/max()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 824 matching lines @@
                                       bool open_in_new_tab) {
   std::string url_copy(url);
 
   // Empty |url_copy| is ok, and will effectively be a reload.
   // Skip the code below so an empty URL does not turn into "http://", which
   // will cause GURL to fail a DCHECK.
   if (!url_copy.empty()) {
     // If |url_copy| starts with '#', then it's for the same URL with a
     // different URL fragment.
     if (url_copy[0] == '#') {
-      url_copy = url_ + url_copy;
+      // if '#' is already present in |url_| then remove old tag and add new
+      // |url_copy| tag.
+      std::size_t found_idx = url_.find('#');
+      if (found_idx != std::string::npos)
+        url_copy = url_.substr(0, found_idx) + url_copy;
+      else
+        url_copy = url_ + url_copy;
+
+      if (!open_in_new_tab) {
+        found_idx = url_copy.find('#');

[Lei Zhang, 2015/01/07 23:08:43]

There's some weird problems with OOP PDF. Without this if-block, open a new tab,
go to http://examples.itextpdf.com/results/part1/chapter02/movie_links_1.pdf,
scroll to the last page, and click the #US link -> results in no navigation.
Clicking it a second time works.

The other issue is when it does work, we are not simply scrolling to the page
with the anchor. Instead, we are reloading the document. We shouldn't have to
reload. This may be out of the scope of this CL, but I want to mention it.

In-Process PDF doesn't have these problems, but it does suffer from the #US#US
issue.

+        if (found_idx != std::string::npos) {
+          int page_number =
+              engine_->GetNamedDestinationPage(url_copy.substr(found_idx + 1));
+          if (page_number >= 0)
+            ScrollToPage(page_number);
+        }
+      }
     }
     // If there's no scheme, add http.
     if (url_copy.find("://") == std::string::npos &&
         url_copy.find("mailto:") == std::string::npos) {
       url_copy = std::string("http://") + url_copy;
     }
     // Make sure |url_copy| starts with a valid scheme.
     if (url_copy.find("http://") != 0 &&
         url_copy.find("https://") != 0 &&
         url_copy.find("ftp://") != 0 &&
@@ skipping 526 matching lines @@
 pp::FloatPoint OutOfProcessInstance::BoundScrollOffsetToDocument(
     const pp::FloatPoint& scroll_offset) {
   float max_x = document_size_.width() * zoom_ - plugin_dip_size_.width();
   float x = std::max(std::min(scroll_offset.x(), max_x), 0.0f);
   float max_y = document_size_.height() * zoom_ - plugin_dip_size_.height();
   float y = std::max(std::min(scroll_offset.y(), max_y), 0.0f);
   return pp::FloatPoint(x, y);
 }
 
 }  // namespace chrome_pdf