Navigation to relative fragments does not work correctly for OOP pdf.

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 12 matching lines @@
 #include "ppapi/c/ppb_core.h"
 #include "ppapi/c/private/ppb_pdf.h"
 #include "ppapi/cpp/dev/memory_dev.h"
 #include "ppapi/cpp/input_event.h"
 #include "ppapi/cpp/instance.h"
 #include "ppapi/cpp/module.h"
 #include "ppapi/cpp/private/pdf.h"
 #include "ppapi/cpp/trusted/browser_font_trusted.h"
 #include "ppapi/cpp/url_response_info.h"
 #include "ppapi/cpp/var.h"
+#include "ppapi/cpp/var_dictionary.h"
 #include "third_party/pdfium/fpdfsdk/include/fpdf_ext.h"
 #include "third_party/pdfium/fpdfsdk/include/fpdf_flatten.h"
 #include "third_party/pdfium/fpdfsdk/include/fpdf_searchex.h"
 #include "third_party/pdfium/fpdfsdk/include/fpdf_sysfontinfo.h"
 #include "third_party/pdfium/fpdfsdk/include/fpdf_transformpage.h"
 #include "third_party/pdfium/fpdfsdk/include/fpdfedit.h"
 #include "third_party/pdfium/fpdfsdk/include/fpdfppo.h"
 #include "third_party/pdfium/fpdfsdk/include/fpdfsave.h"
 #include "third_party/pdfium/fpdfsdk/include/pdfwindow/PDFWindow.h"
 #include "third_party/pdfium/fpdfsdk/include/pdfwindow/PWL_FontMap.h"
@@ skipping 1138 matching lines @@
     need_update = true;
     if (IsPageVisible(i))
       client_->Invalidate(GetPageScreenRect(i));
   }
   if (need_update)
     LoadPageInfo(true);
 
   FinishLoadingDocument();
 }
 
+pp::VarDictionary PDFiumEngine::GetAllNamedDestinations() {

[raymes, 2015/01/14 00:19:01]

nit: Can we move this function down near GetNamedDestinationPage?

[Deepak, 2015/01/14 06:29:01]

Done.

+  pp::VarDictionary named_destinations;
+  for (unsigned long i = 0; i < GetNameDestCount(); i++) {

[raymes, 2015/01/14 00:19:01]

Sorry when I said "inline" I just meant actually copying the code into here.
It's not worth having a separate function to get the count

[Deepak, 2015/01/14 06:29:01]

Done.

+    base::string16 name;
+    size_t buffer_bytes;

[raymes, 2015/01/14 00:19:01]

use unsigned long here (as in the API)

[Deepak, 2015/01/14 06:29:01]

Done.

+    FPDF_GetNamedDest(doc_, i, NULL, buffer_bytes);
+    if (buffer_bytes > 1) {

[raymes, 2015/01/14 00:19:01]

We should compute the length of the string here because WriteInto takes the
length in chars and not the size of the buffer. The length includes the null
character. Divide buffer_length by sizeof(base::string16::value_type) to get
name_length

if (name_length > 1) 
  ... 
  ... WriteInto(..., name_length)

[Deepak, 2015/01/14 06:29:01]

Done.

+      FPDF_DEST dest = FPDF_GetNamedDest(
+          doc_, i, WriteInto(&name, buffer_bytes + 1), buffer_bytes);
+      if (dest) {
+        std::string name_dest = base::UTF16ToUTF8(name);
+        int page_number = GetNamedDestinationPage(name_dest);
+        if (page_number >= 0) {
+          named_destinations.Set(pp::Var(name_dest.c_str()),
+                                 pp::Var(page_number));
+        }
+      }
+    }
+  }
+  return named_destinations;
+}
+
 void PDFiumEngine::FinishLoadingDocument() {
   DCHECK(doc_loader_.IsDocumentComplete() && doc_);
   if (called_do_document_action_)
     return;
   called_do_document_action_ = true;
 
   // These can only be called now, as the JS might end up needing a page.
   FORM_DoDocumentJSAction(form_);
   FORM_DoDocumentOpenAction(form_);
   if (most_visible_page_ != -1) {
@@ skipping 2715 matching lines @@
     double* height) {
   FPDF_DOCUMENT doc = FPDF_LoadMemDocument(pdf_buffer, pdf_buffer_size, NULL);
   if (!doc)
     return false;
   bool success = FPDF_GetPageSizeByIndex(doc, page_number, width, height) != 0;
   FPDF_CloseDocument(doc);
   return success;
 }
 
 }  // namespace chrome_pdf