Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 83043003: [cr tool] Adding the prepare command (Closed)

Created:
7 years, 1 month ago by ian_cottrell
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changing exit to raise for no overidden test. #

Patch Set 3 : Quote change #

Patch Set 4 : Quote change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
tools/cr/cr/commands/prepare.py View 1 2 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ian_cottrell
7 years, 1 month ago (2013-11-22 15:34:52 UTC) #1
bulach
lgtm, thanks! ignorable suggestion below: https://codereview.chromium.org/83043003/diff/1/tools/cr/cr/commands/prepare.py File tools/cr/cr/commands/prepare.py (right): https://codereview.chromium.org/83043003/diff/1/tools/cr/cr/commands/prepare.py#newcode47 tools/cr/cr/commands/prepare.py:47: print 'Prepare "{0}" not ...
7 years, 1 month ago (2013-11-22 15:40:34 UTC) #2
ian_cottrell
On 2013/11/22 15:40:34, bulach wrote: > lgtm, thanks! ignorable suggestion below: > > https://codereview.chromium.org/83043003/diff/1/tools/cr/cr/commands/prepare.py > ...
7 years, 1 month ago (2013-11-22 15:56:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iancottrell@chromium.org/83043003/100001
7 years, 1 month ago (2013-11-22 20:23:41 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-23 20:49:27 UTC) #5
Message was sent while issue was closed.
Change committed as 236969

Powered by Google App Engine
This is Rietveld 408576698