Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc

Issue 830423010: Temporarily disabling new gUM test on Mac since it's broken. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <ctime> 5 #include <ctime>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_enumerator.h" 8 #include "base/files/file_enumerator.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
(...skipping 616 matching lines...) Expand 10 before | Expand all | Expand 10 after
627 ASSERT_TRUE(recorder.StartRecording(recording_time, recording, false, true)); 627 ASSERT_TRUE(recorder.StartRecording(recording_time, recording, false, true));
628 628
629 NegotiateCall(left_tab, right_tab); 629 NegotiateCall(left_tab, right_tab);
630 630
631 ASSERT_TRUE(recorder.WaitForRecordingToEnd()); 631 ASSERT_TRUE(recorder.WaitForRecordingToEnd());
632 DVLOG(0) << "Done recording to " << recording.value() << std::endl; 632 DVLOG(0) << "Done recording to " << recording.value() << std::endl;
633 633
634 HangUp(left_tab); 634 HangUp(left_tab);
635 } 635 }
636 636
637 #if defined(OS_MACOSX)
638 // Broken on Mac for some reason: http://crbug.com/446859.
639 #define MAYBE_MANUAL_TestCallQualityWithAudioFromFakeDevice \
640 DISABLED_MANUAL_TestCallQualityWithAudioFromFakeDevice
641 #else
642 #define MAYBE_MANUAL_TestCallQualityWithAudioFromFakeDevice \
643 MANUAL_TestCallQualityWithAudioFromFakeDevice
644 #endif
645
637 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest, 646 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest,
638 MANUAL_TestCallQualityWithAudioFromFakeDevice) { 647 MAYBE_MANUAL_TestCallQualityWithAudioFromFakeDevice) {
639 if (OnWinXp() || OnWin8()) { 648 if (OnWinXp() || OnWin8()) {
640 // http://crbug.com/379798. 649 // http://crbug.com/379798.
641 LOG(ERROR) << "This test is not implemented for Windows XP/Win8."; 650 LOG(ERROR) << "This test is not implemented for Windows XP/Win8.";
642 return; 651 return;
643 } 652 }
644 653
645 base::FilePath reference_file = 654 base::FilePath reference_file =
646 test::GetReferenceFilesDir().Append(kReferenceFile); 655 test::GetReferenceFilesDir().Append(kReferenceFile);
647 base::FilePath recording = CreateTemporaryWaveFile(); 656 base::FilePath recording = CreateTemporaryWaveFile();
648 657
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
792 #endif 801 #endif
793 802
794 // Since the AGC is off here there should be no gain at all. 803 // Since the AGC is off here there should be no gain at all.
795 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest, 804 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest,
796 MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff) { 805 MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff) {
797 const char* kAudioCallWithoutAudioProcessing = 806 const char* kAudioCallWithoutAudioProcessing =
798 "{audio: { mandatory: { echoCancellation: false } } }"; 807 "{audio: { mandatory: { echoCancellation: false } } }";
799 ASSERT_NO_FATAL_FAILURE(TestAutoGainControl( 808 ASSERT_NO_FATAL_FAILURE(TestAutoGainControl(
800 kAgcTestReferenceFile, kAudioCallWithoutAudioProcessing, "_no_agc")); 809 kAgcTestReferenceFile, kAudioCallWithoutAudioProcessing, "_no_agc"));
801 } 810 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698