Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 830423008: Revert of Further instrumentations to find jank in Windows message processing. (Closed)

Created:
5 years, 11 months ago by falken
Modified:
5 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Further instrumentations to find jank in Windows message processing. (patchset #1 id:1 of https://codereview.chromium.org/835183002/) Reason for revert: Speculative revert for Windows failures on Blink waterfall. They also appear on the trybots so will try a tryjob first. Original issue's description: > Further instrumentations to find jank in Windows message processing. > Based on the latest revelations: > 440919 WindowImpl::WndProc2 = 90 jph. > Since the internals of OnWndProc are instrumented, this strangely indicates that it's GetWindowUserData who is responsible for this jank. Instrumenting it. > > 440919 <<MessagePumpForUI::ProcessNextWindowsMessage>> = 46 jph and > 440919 MessagePumpForUI::ProcessMessageHelper = 39 jph > This means that with instrumenting MessagePumpForUI::ProcessMessageHelper, we've divided MessagePumpForUI::ProcessNextWindowsMessage into 2 roughly equal parts: everything that happens inside MessagePumpForUI::ProcessMessageHelper, and everything outside (GetQueueStatus and PeekMessage). > Adding in instrumentation to separate GetQueueStatus from PeekMessage. > Also instrumenting internals of MessagePumpForUI::ProcessMessageHelper. > > BUG=440919 > > Committed: https://crrev.com/4949a513d841da01d66a32f54a98fec518c3fde3 > Cr-Commit-Position: refs/heads/master@{#310156} TBR=cpu@chromium.org,vadimt@chromium.org NOTREECHECKS=true NOTRY=true BUG=440919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -29 lines) Patch
M base/message_loop/message_pump_win.cc View 5 chunks +4 lines, -24 lines 0 comments Download
M ui/gfx/win/hwnd_util.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
falken
Created Revert of Further instrumentations to find jank in Windows message processing.
5 years, 11 months ago (2015-01-07 02:50:35 UTC) #1
falken
5 years, 11 months ago (2015-01-07 03:23:46 UTC) #2
On 2015/01/07 02:50:35, falken wrote:
> Created Revert of Further instrumentations to find jank in Windows message
> processing.

This patch is innocent, the failures still occur. Closing this issue.

Powered by Google App Engine
This is Rietveld 408576698