Issue 830393004: Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 830393004: Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment. (Closed)

Created:
5 years, 11 months ago by Albert Bodenhamer

Modified:
5 years, 11 months ago

Reviewers:
dzhioev (left Google), Mr4D (OOO till 08-26), merkulova

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment. (patchset #3 id:40001 of https://codereview.chromium.org/783663003/) Reason for revert: Appears to have caused bug 446212 Original issue's description: > Special check on Supervised User creation flow added to prevent misleading shelf alignment. > > BUG=405361 > > Committed: https://crrev.com/e2b59c4c229ec214150f522f4b3f6b02d9cefaee > Cr-Commit-Position: refs/heads/master@{#309555} TBR=dzhioev@chromium.org,skuhne@chromium.org,merkulova@chromium.org NOTREECHECKS=true NOTRY=true BUG=405361 Committed: https://crrev.com/e2e8ff56d1937bb635884032534def9fc42b7809 Cr-Commit-Position: refs/heads/master@{#310145}

Patch Set 1 #

Created: 5 years, 11 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	ash/shelf/shelf_layout_manager.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Albert Bodenhamer

Created Revert of Special check on Supervised User creation flow added to prevent misleading shelf ...

5 years, 11 months ago (2015-01-06 21:09:19 UTC) #1

merkulova

5 years, 10 months ago (2015-02-04 11:45:23 UTC) #2

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/871353003/ by merkulova@chromium.org.

The reason for reverting is: The bug is not reproducible anymore. Some fixes to
shelf were done earlier, may be that prevents that one problem.

Expand Messages | Collapse Messages