Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 830293003: Make control reducer revisit newly introduced merges. (Closed)

Created:
5 years, 11 months ago by Jarin
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
titzer, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make control reducer revisit newly introduced merges. TEST=mjsunit/compiler/regress-445876 BUG=chromium:445876 LOG=N Committed: https://crrev.com/a9716d98401d65273f7adfcca906dbd088776a01 Cr-Commit-Position: refs/heads/master@{#25959}

Patch Set 1 #

Patch Set 2 : Use revisit queue #

Patch Set 3 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M src/compiler/control-reducer.cc View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
A + test/mjsunit/compiler/regress-445876.js View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Jarin
Could you take a look, please?
5 years, 11 months ago (2015-01-05 12:31:20 UTC) #2
Benedikt Meurer
LGTM
5 years, 11 months ago (2015-01-05 12:32:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830293003/1
5 years, 11 months ago (2015-01-05 12:32:14 UTC) #5
titzer
lgtm
5 years, 11 months ago (2015-01-05 12:35:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/565)
5 years, 11 months ago (2015-01-05 13:09:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830293003/40001
5 years, 11 months ago (2015-01-05 16:08:54 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-05 16:35:20 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 16:35:51 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a9716d98401d65273f7adfcca906dbd088776a01
Cr-Commit-Position: refs/heads/master@{#25959}

Powered by Google App Engine
This is Rietveld 408576698