Remove impl-side-painting from about:flags

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 1053 matching lines @@
 }
 
 static void AppendCompositorCommandLineFlags(base::CommandLine* command_line) {
   if (IsPinchVirtualViewportEnabled())
     command_line->AppendSwitch(cc::switches::kEnablePinchVirtualViewport);
 
   if (IsDelegatedRendererEnabled())
     command_line->AppendSwitch(switches::kEnableDelegatedRenderer);
 
   if (IsImplSidePaintingEnabled()) {
-    command_line->AppendSwitch(switches::kEnableImplSidePainting);
     command_line->AppendSwitchASCII(
         switches::kNumRasterThreads,
         base::IntToString(NumberOfRendererRasterThreads()));
+  } else {
+    command_line->AppendSwitch(switches::kDisableImplSidePainting);

[no sievers, 2015/01/09 20:22:32]

So this was broken before in that it didn't propagate the cmdline to the
renderer?

[danakj, 2015/01/09 20:23:14]

No the renderer was looking for enable before. Now it'll look for disable
instead. See the RenderThreadImpl change.

[danakj, 2015/01/09 21:32:52]

Tho it appears that at least in the RenderThreadImplBrowserTest (which are not
actually browser tests...), implside painting was not previously enabled. Will
fix.

   }
 
   if (IsGpuRasterizationEnabled())
     command_line->AppendSwitch(switches::kEnableGpuRasterization);
 
   if (IsForceGpuRasterizationEnabled())
     command_line->AppendSwitch(switches::kForceGpuRasterization);
 
   if (BrowserGpuChannelHostFactory::IsGpuMemoryBufferFactoryUsageEnabled(
           gfx::GpuMemoryBuffer::MAP)) {
@@ skipping 1270 matching lines @@
 
 void RenderProcessHostImpl::DecrementWorkerRefCount() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   DCHECK_GT(worker_ref_count_, 0);
   --worker_ref_count_;
   if (worker_ref_count_ == 0)
     Cleanup();
 }
 
 }  // namespace content