Basic autofill into password value on user gesture only.

components/autofill/content/renderer/password_autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
 
 #include <map>
 #include <vector>
 
 #include "base/memory/linked_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 #include "content/public/renderer/render_view_observer.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
+#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
 
 namespace blink {
 class WebInputElement;
 class WebKeyboardEvent;
 class WebSecurityOrigin;
 class WebView;
 }
 
 namespace autofill {
 
@@ skipping 46 matching lines @@
   struct PasswordInfo {
     blink::WebInputElement password_field;
     PasswordFormFillData fill_data;
     bool backspace_pressed_last;
     PasswordInfo() : backspace_pressed_last(false) {}
   };
   typedef std::map<blink::WebElement, PasswordInfo> LoginToPasswordInfoMap;
   typedef std::map<blink::WebFrame*,
                    linked_ptr<PasswordForm> > FrameToPasswordFormMap;
 
+  class AutofillWebUserGestureHandler : public blink::WebUserGestureHandler {
+   public:
+    AutofillWebUserGestureHandler(PasswordAutofillAgent* agent);
+    virtual ~AutofillWebUserGestureHandler();
+
+    void addElement(blink::WebInputElement* element) {
+      elements_.push_back(element);
+    }
+
+    virtual void onGesture();
+
+   private:
+    PasswordAutofillAgent* agent_;
+    std::vector<blink::WebInputElement*> elements_;
+  };
+
   // RenderViewObserver:
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
   virtual void DidStartProvisionalLoad(blink::WebFrame* frame) OVERRIDE;
   virtual void DidStartLoading() OVERRIDE;
   virtual void DidFinishDocumentLoad(blink::WebFrame* frame) OVERRIDE;
   virtual void DidFinishLoad(blink::WebFrame* frame) OVERRIDE;
   virtual void FrameDetached(blink::WebFrame* frame) OVERRIDE;
   virtual void FrameWillClose(blink::WebFrame* frame) OVERRIDE;
   virtual void WillSendSubmitEvent(blink::WebFrame* frame,
                                    const blink::WebFormElement& form) OVERRIDE;
@@ skipping 45 matching lines @@
   // Finds login information for a |node| that was previously filled.
   bool FindLoginInfo(const blink::WebNode& node,
                      blink::WebInputElement* found_input,
                      PasswordInfo* found_password);
 
   // If |provisionally_saved_forms_| contains a form for |current_frame| or its
   // children, return such frame.
   blink::WebFrame* CurrentOrChildFrameWithSavedForms(
       const blink::WebFrame* current_frame);
 
+  void setUserGestureOccurred(bool occurred) {

[Garrett Casto, 2013/12/02 23:49:12]

Inline functions like this are generally also done in hacker_case, so
set_user_gesture_occurred(). http://www.chromium.org/developers/coding-style

[jww, 2013/12/03 06:29:59]

Done.

+    userGestureOccurred_ = occurred;
+  }
+
   // The logins we have filled so far with their associated info.
   LoginToPasswordInfoMap login_to_password_info_;
 
   // Used for UMA stats.
   OtherPossibleUsernamesUsage usernames_usage_;
 
   // Pointer to the WebView. Used to access page scale factor.
   blink::WebView* web_view_;
 
   // Set if the user might be submitting a password form on the current page,
   // but the submit may still fail (i.e. doesn't pass JavaScript validation).
   FrameToPasswordFormMap provisionally_saved_forms_;
 
   base::WeakPtrFactory<PasswordAutofillAgent> weak_ptr_factory_;

[Garrett Casto, 2013/12/02 23:49:12]

WeakPtrFactory should always be the last member variable. See
https://code.google.com/p/chromium/codesearch#chromium/src/base/memory/weak_p...

[jww, 2013/12/03 06:29:59]

Done.

 
+  AutofillWebUserGestureHandler* gestureHandler_;

[Garrett Casto, 2013/12/02 23:49:12]

These should be unix_hacker_style_ not mixedCase_.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Variab...

[jww, 2013/12/03 06:29:59]

Done.

+
+  bool userGestureOccurred_;
+
   DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_