Issue 83023010: Remove ExtensionPrefs's dependency on ChromeAppSorting.

Issue 83023010: Remove ExtensionPrefs's dependency on ChromeAppSorting. (Closed)

Created:
7 years, 1 month ago by Daniel Erat

Modified:
7 years ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, benwells, James Cook

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove ExtensionPrefs's dependency on ChromeAppSorting. Instead of having ExtensionPrefs construct a ChromeAppSorting object directly, make ExtensionPrefsFactory pass an AppSorting object to it. BUG=313284 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236967

Patch Set 1 #

Patch Set 2 : fix test compilation #

Patch Set 3 : remove chrome_app_sorting.h include from extension_prefs.cc #

Patch Set 4 : change a LOG(INFO) that i know nothing about to a VLOG(1) #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -18 lines)			Patch
M	chrome/browser/extensions/chrome_app_sorting.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/chrome_app_sorting.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/chrome_extensions_browser_client.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/chrome_extensions_browser_client.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.h	View		4 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View	1 2 3	6 chunks	+17 lines, -13 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs_factory.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/test_extension_prefs.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/test_extension_system.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	extensions/browser/app_sorting.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	extensions/browser/extensions_browser_client.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/83023010/80001

7 years, 1 month ago (2013-11-23 00:24:10 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=37780

7 years, 1 month ago (2013-11-23 00:37:31 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/83023010/190001

7 years, 1 month ago (2013-11-23 01:19:21 UTC) #5

Message was sent while issue was closed.

Change committed as 236967

Expand Messages | Collapse Messages