Issue 83023006: Remove plugin_list param from MetricsLog::RecordStabilityMetrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83023006: Remove plugin_list param from MetricsLog::RecordStabilityMetrics. (Closed)

Created:
7 years ago by Alexei Svitkine (slow)

Modified:
7 years ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove plugin_list param from MetricsLog::RecordStabilityMetrics. Instead, use the list of plugins that have already been set on the system profile. This makes the API simpler and paves way for my upcoming change to log initial stability metrics in their own log. The new code is also slightly more efficient, since there's fewer string conversions. Also adds tests coverage for the functionality, which was previously untested. BUG=312733 TEST=New unit test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236929

Patch Set 1 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -34 lines)			Patch
M	chrome/browser/metrics/metrics_log.h	View	2 chunks	+6 lines, -9 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log.cc	View	6 chunks	+12 lines, -18 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log_unittest.cc	View	6 chunks	+80 lines, -5 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/83023006/430001

7 years ago (2013-11-23 00:50:57 UTC) #3

Message was sent while issue was closed.

Change committed as 236929

Expand Messages | Collapse Messages