Add VideoTrackSink interface to content/public

content/public/renderer/media_stream_video_sink.h

Index: content/public/renderer/media_stream_video_sink.h
diff --git a/content/public/renderer/media_stream_video_sink.h b/content/public/renderer/media_stream_video_sink.h
new file mode 100644
index 0000000000000000000000000000000000000000..8fd134558579e7be8874b66986965e751fdfe055
--- /dev/null
+++ b/content/public/renderer/media_stream_video_sink.h
@@ -0,0 +1,44 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_RENDERER_MEDIA_STREAM_VIDEO_SINK_H_
+#define CONTENT_PUBLIC_RENDERER_MEDIA_STREAM_VIDEO_SINK_H_
+
+#include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"
+#include "content/common/content_export.h"
+#include "content/public/renderer/media_stream_sink.h"
+
+namespace media {
+class VideoFrame;
+}
+
+namespace blink {
+class WebMediaStreamTrack;
+}
+
+namespace content {
+
+class CONTENT_EXPORT MediaStreamVideoSink : public MediaStreamSink {

[no longer working on chromium, 2013/11/27 10:12:42]

Just an idea.
the sink interfaces for audio and video are small and simple, I am wondering if
we should put them into one file. like:
class CONTENT_EXPORT MediaStreamSink {
  class VideoSink {
   public:
    virtual void OnVideoFrame(const scoped_refptr<media::VideoFrame>& frame) =
0;
   protected:
    virtual ~VideoSink() {}
  }

  class AudioSink {
   public:
    virtual void OnAudioData(const int16* data, int sample_rate, int channels,
int frames) = 0;
    virtual void OnSetFormat(const media::AudioParameters& params) = 0;
   protected:
    virtual ~AudioSink() {}
  }
}

CONTENT_EXPORT void AddToAudioTrack(
    MediaStreamSink::AudioSink* sink, const blink::WebMediaStreamTrack& track);

CONTENT_EXPORT void RemoveFromAudioTrack(
    MediaStreamSink::AudioSink* sink, const blink::WebMediaStreamTrack& track);

CONTENT_EXPORT void AddToVideoTrack(
    MediaStreamSink::VideoSink* sink, const blink::WebMediaStreamTrack& track);

CONTENT_EXPORT void RemoveFromVideoTrack(
    MediaStreamSink::VideoSink* sink, const blink::WebMediaStreamTrack& track);

[perkj_chrome, 2013/11/27 15:29:13]

Discussed off line.

Added AddToVideoTrack and RemoveFromVideoTrack and removed the statics.

+ public:
+  virtual void OnVideoFrame(const scoped_refptr<media::VideoFrame>& frame) = 0;
+
+  // An implementation of MediaStreamVideoSink should call AddToTrack when it
+  // is ready to receive data from a track. Before the implementation is
+  // destroyed, RemoveFromTrack must be called.
+  static void AddToTrack(MediaStreamVideoSink* sink,

[no longer working on chromium, 2013/11/27 10:12:42]

these two interface should not be in the MediaStreamVideoSink. Extract them out
and use CONTENT_EXPORT.

[perkj_chrome, 2013/11/27 15:29:13]

Done.

+                         const blink::WebMediaStreamTrack& track);
+  static void RemoveFromTrack(MediaStreamVideoSink* sink,
+                              const blink::WebMediaStreamTrack& track);
+
+ protected:
+  virtual ~MediaStreamVideoSink() {}
+};
+
+
+
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_RENDERER_MEDIA_STREAM_VIDEO_SINK_H_