content/public/renderer/media_stream_sink.h - Issue 83023005: Add VideoTrackSink interface to content/public

Side by Side Diff: content/public/renderer/media_stream_sink.h

Issue 83023005: Add VideoTrackSink interface to content/public (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added AddToVideoTrack Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_PUBLIC_RENDERER_MEDIA_STREAM_SINK_H_

	6 #define CONTENT_PUBLIC_RENDERER_MEDIA_STREAM_SINK_H_

	7

	8 #include "base/compiler_specific.h"

	9 #include "content/common/content_export.h"

	10 #include "third_party/WebKit/public/platform/WebMediaStreamSource.h"

	11

	12 namespace content {

	13

	14 class CONTENT_EXPORT MediaStreamSink {
	tommi (sloooow) - chröme 2013/11/27 16:53:07 t'would be nice to have some comments t'would be nice to have some comments perkj_chrome 2013/11/28 13:32:45 Done. Show quoted text On 2013/11/27 16:53:07, tommi wrote: > t'would be nice to have some comments Done.
	15 public:

	16 virtual void OnReadyStateChanged(

	17 blink::WebMediaStreamSource::ReadyState state) {}
	tommi (sloooow) - chröme 2013/11/27 16:53:07 = 0? since there's only one method in the interfac = 0? since there's only one method in the interface currently, it seems like nobody would want to inherit from it without overriding this function. Jói 2013/11/27 18:35:51 The interfaces MediaStreamVideoSink and MediaStrea Show quoted text On 2013/11/27 16:53:07, tommi wrote: > = 0? > since there's only one method in the interface currently, it seems like nobody > would want to inherit from it without overriding this function. The interfaces MediaStreamVideoSink and MediaStreamAudioSink which inherit from this one have more methods and somebody implementing them might not want to implement OnReadyStateChanged. perkj_chrome 2013/11/28 13:32:45 I agree with Joi. This is not needed by all implem Show quoted text On 2013/11/27 18:35:51, Jói wrote: > On 2013/11/27 16:53:07, tommi wrote: > > = 0? > > since there's only one method in the interface currently, it seems like nobody > > would want to inherit from it without overriding this function. > > The interfaces MediaStreamVideoSink and MediaStreamAudioSink which inherit from > this one have more methods and somebody implementing them might not want to > implement OnReadyStateChanged. I agree with Joi. This is not needed by all implementations but belong to a common base class. tommi (sloooow) - chröme 2013/11/28 14:32:21 OK, sounds good. Show quoted text On 2013/11/28 13:32:45, perkj wrote: > On 2013/11/27 18:35:51, Jói wrote: > > On 2013/11/27 16:53:07, tommi wrote: > > > = 0? > > > since there's only one method in the interface currently, it seems like > nobody > > > would want to inherit from it without overriding this function. > > > > The interfaces MediaStreamVideoSink and MediaStreamAudioSink which inherit > from > > this one have more methods and somebody implementing them might not want to > > implement OnReadyStateChanged. > > I agree with Joi. This is not needed by all implementations but belong to a > common base class. > OK, sounds good.
	18

	19 protected:

	20 virtual ~MediaStreamSink() {}

	21 };

	22

	23 } // namespace content

	24

	25 #endif // CONTENT_PUBLIC_RENDERER_MEDIA_STREAM_SINK_H_

OLD	NEW

« no previous file with comments | « content/content_renderer.gypi ('k') | content/public/renderer/media_stream_video_sink.h » ('j') | content/public/renderer/media_stream_video_sink.h » ('J')