components/policy/core/common/policy_service_impl.h - Issue 830193002: Using PolicyServiceWatcher instead of PolicyWatcherLinux/Win/Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/policy_service_impl.h

Issue 830193002: Using PolicyServiceWatcher instead of PolicyWatcherLinux/Win/Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed code review feedback from Mattias. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/policy_loader_mac.mm ('K') | « components/policy/core/common/policy_loader_mac.mm ('k') | components/policy/core/common/policy_service_impl.cc » ('j') | remoting/host/policy_hack/policy_service_watcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/policy_service_impl.h

diff --git a/components/policy/core/common/policy_service_impl.h b/components/policy/core/common/policy_service_impl.h

index e74141a6bd9b766443d8b991268c9f5b10ca4a96..f90d377e4893897fbc79264e69d3a9d1164d45ca 100644

--- a/components/policy/core/common/policy_service_impl.h

+++ b/components/policy/core/common/policy_service_impl.h

@@ -14,6 +14,7 @@

#include "base/callback.h"

#include "base/memory/weak_ptr.h"

#include "base/observer_list.h"

+#include "base/threading/thread_checker.h"

#include "components/policy/core/common/configuration_policy_provider.h"

#include "components/policy/core/common/policy_bundle.h"

#include "components/policy/core/common/policy_service.h"

@@ -94,6 +95,9 @@ class POLICY_EXPORT PolicyServiceImpl

// processing previous policy updates.

base::WeakPtrFactory<PolicyServiceImpl> update_task_ptr_factory_;

+ // Used to verify thread-safe usage (mostly wrt observers_).

Mattias Nissler (ping if slow) 2015/01/08 09:58:37 nit: drop the fragment in parentheses.

Łukasz Anforowicz 2015/01/08 23:09:27 Oh, right. I forgot about this when responding to

+ base::ThreadChecker thread_checker_;

DISALLOW_COPY_AND_ASSIGN(PolicyServiceImpl);

};