Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: remoting/host/policy_hack/policy_watcher.cc

Issue 830193002: Using PolicyServiceWatcher instead of PolicyWatcherLinux/Win/Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed building for Chrome OS. Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/policy_hack/policy_watcher.cc
diff --git a/remoting/host/policy_hack/policy_watcher.cc b/remoting/host/policy_hack/policy_watcher.cc
index d0f59572c31ed2480d409bea355a8b5e68d89515..b8f053d8207e9e33ca7e8bc51384ad851b830ed8 100644
--- a/remoting/host/policy_hack/policy_watcher.cc
+++ b/remoting/host/policy_hack/policy_watcher.cc
@@ -12,7 +12,6 @@
#include "base/location.h"
#include "base/memory/weak_ptr.h"
#include "base/single_thread_task_runner.h"
-#include "base/time/time.h"
#include "base/values.h"
#include "remoting/host/dns_blackhole_checker.h"
@@ -25,10 +24,6 @@ namespace policy_hack {
namespace {
-// The time interval for rechecking policy. This is our fallback in case the
-// delegate never reports a change to the ReloadObserver.
-const int kFallbackReloadDelayMinutes = 15;
-
// Copies all policy values from one dictionary to another, using values from
// |default| if they are not set in |from|, or values from |bad_type_values| if
// the value in |from| has the wrong type.
@@ -116,7 +111,7 @@ const char PolicyWatcher::kHostDebugOverridePoliciesName[] =
"RemoteAccessHostDebugOverridePolicies";
PolicyWatcher::PolicyWatcher(
- scoped_refptr<base::SingleThreadTaskRunner> task_runner)
+ const scoped_refptr<base::SingleThreadTaskRunner>& task_runner)
: task_runner_(task_runner),
transient_policy_error_retry_counter_(0),
old_policies_(new base::DictionaryValue()),
@@ -183,20 +178,6 @@ void PolicyWatcher::StopWatchingOnPolicyWatcherThread() {
policy_error_callback_.Reset();
}
-void PolicyWatcher::ScheduleFallbackReloadTask() {
- DCHECK(OnPolicyWatcherThread());
- ScheduleReloadTask(
- base::TimeDelta::FromMinutes(kFallbackReloadDelayMinutes));
-}
-
-void PolicyWatcher::ScheduleReloadTask(const base::TimeDelta& delay) {
- DCHECK(OnPolicyWatcherThread());
- task_runner_->PostDelayedTask(
- FROM_HERE,
- base::Bind(&PolicyWatcher::Reload, weak_factory_.GetWeakPtr()),
- delay);
-}
-
const base::DictionaryValue& PolicyWatcher::Defaults() const {
return *default_values_;
}

Powered by Google App Engine
This is Rietveld 408576698