Chromium Code Reviews Chromium Code Reviews
Issue 830183005:
Re-enable the activation behavior of media elements (click to play/pause) (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/media/activation-behavior-shadow.html |
| diff --git a/LayoutTests/media/activation-behavior-shadow.html b/LayoutTests/media/activation-behavior-shadow.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..c8703dfccf8af3aecbe0843d40e2120baacc07cf |
| --- /dev/null |
| +++ b/LayoutTests/media/activation-behavior-shadow.html |
| @@ -0,0 +1,45 @@ |
| +<!doctype html> |
| +<title>activation behavior with shadow children</title> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<video controls></video> |
| +<script> |
| +function shouldTogglePlayState(shadowChild) |
| +{ |
| + var id = internals.shadowPseudoId(shadowChild); |
| + if (id == "-webkit-media-controls") |
| + return true; |
| + if (id == "-webkit-media-controls-play-button") |
| + return true; |
| + if (id == "-webkit-media-controls-panel") |
| + return false; |
| + return shouldTogglePlayState(shadowChild.parentNode); |
| +} |
| + |
| +function shouldClick(shadowChild) |
| +{ |
| + var id = internals.shadowPseudoId(shadowChild); |
| + // The cast buttons are only visible if there are remote routes. Clicking |
| + // when not visible violates sound assumptions made in HTMLMediaElement. |
|
aberent
2015/01/08 16:22:36
Should you apply similar logic to the closed capti
philipj_slow
2015/01/08 22:59:56
HTMLMediaElement::setClosedCaptionsVisible has an
|
| + if (id == "-internal-media-controls-cast-button") |
| + return false; |
| + if (id == "-internal-media-controls-overlay-cast-button") |
| + return false; |
| + return true; |
| +} |
| + |
| +test(function() |
| +{ |
| + var v = document.querySelector("video"); |
| + var shadowChildren = internals.shadowRoot(v).querySelectorAll("*"); |
| + shadowChildren = Array.prototype.filter.call(shadowChildren, shouldClick); |
| + shadowChildren.forEach(function(shadowChild) |
| + { |
| + v.pause(); |
| + shadowChild.click(); |
| + assert_equals(v.paused, !shouldTogglePlayState(shadowChild), |
| + "paused state after click element with pseudo id '" |
| + + internals.shadowPseudoId(shadowChild) + "'"); |
| + }); |
| +}); |
| +</script> |
