Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 830133003: ONC: Remove the top level fields NameServers and SearchDomains. (Closed)

Created:
5 years, 11 months ago by pneubeck (no reviews)
Modified:
5 years, 11 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ONC: Remove the top level fields NameServers and SearchDomains. These were unused and unsupported and conflict upcoming changes. Also clean up some IPConfig documentation and adapt the validation. BUG=411289 Committed: https://crrev.com/53f190ec150986d7953d14d06cb0b7ce649849ca Cr-Commit-Position: refs/heads/master@{#309942}

Patch Set 1 #

Patch Set 2 : Fix IPConfig documentation and adapt validation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -56 lines) Patch
M chromeos/network/onc/onc_normalizer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/network/onc/onc_signature.cc View 2 chunks +1 line, -10 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/onc/docs/onc_spec.html View 1 5 chunks +13 lines, -37 lines 0 comments Download
M components/onc/onc_constants.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/onc/onc_constants.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pneubeck (no reviews)
Separated this from the larger CL https://codereview.chromium.org/749013003/ and also removing SearchDomains.
5 years, 11 months ago (2015-01-04 10:35:13 UTC) #2
stevenjb
lgtm
5 years, 11 months ago (2015-01-05 18:16:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830133003/40001
5 years, 11 months ago (2015-01-05 18:17:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 11 months ago (2015-01-05 19:53:19 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 19:54:09 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/53f190ec150986d7953d14d06cb0b7ce649849ca
Cr-Commit-Position: refs/heads/master@{#309942}

Powered by Google App Engine
This is Rietveld 408576698