Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 830083002: remove unused drawData (Closed)

Created:
5 years, 11 months ago by reed2
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -146 lines) Patch
M experimental/PdfViewer/SkNulCanvas.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +3 lines, -3 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M include/utils/SkLuaCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/utils/SkProxyCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M samplecode/SamplePicture.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkRecords.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/pipe/SkGPipeRead.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 1 1 chunk +0 lines, -16 lines 0 comments Download
M tests/RecorderTest.cpp View 1 1 chunk +0 lines, -14 lines 0 comments Download
M tests/SerializationTest.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830083002/20001
5 years, 11 months ago (2015-01-01 21:52:09 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-01 21:52:09 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 11 months ago (2015-01-02 03:52:12 UTC) #6
robertphillips
lgtm
5 years, 11 months ago (2015-01-02 14:38:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830083002/20001
5 years, 11 months ago (2015-01-02 14:39:31 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-02 14:39:54 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c4fda92f45b9649f233a5b8636618a6431aa59cb

Powered by Google App Engine
This is Rietveld 408576698