Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 830053004: Suppress accessibility events when user is navigating away. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase, disable test for now Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index d32b7cc1dc744a1ad9674bfca7a2f5db2bf6f8e0..84565a2f99f77119f61048fdf2fa74dd51a129b7 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2529,6 +2529,17 @@ void WebContentsImpl::DidStartProvisionalLoad(
observers_,
DidStartProvisionalLoadForFrame(
render_frame_host, validated_url, is_error_page, is_iframe_srcdoc));
+
+ // Notify accessibility if this is a reload.
+ NavigationEntry* entry = controller_.GetVisibleEntry();
+ if (entry && ui::PageTransitionCoreTypeIs(
+ entry->GetTransitionType(), ui::PAGE_TRANSITION_RELOAD)) {
+ FrameTreeNode* ftn = render_frame_host->frame_tree_node();
+ BrowserAccessibilityManager* manager =
+ ftn->current_frame_host()->browser_accessibility_manager();
+ if (manager)
+ manager->UserIsReloading();
+ }
}
void WebContentsImpl::DidStartNavigationTransition(
@@ -2550,6 +2561,12 @@ void WebContentsImpl::DidFailProvisionalLoadWithError(
validated_url,
params.error_code,
params.error_description));
+
+ FrameTreeNode* ftn = render_frame_host->frame_tree_node();
+ BrowserAccessibilityManager* manager =
+ ftn->current_frame_host()->browser_accessibility_manager();
+ if (manager)
+ manager->NavigationFailed();
}
void WebContentsImpl::DidFailLoadWithError(
@@ -2625,6 +2642,11 @@ void WebContentsImpl::DidCommitProvisionalLoad(
observers_,
DidCommitProvisionalLoadForFrame(
render_frame_host, url, transition_type));
+
+ BrowserAccessibilityManager* manager =
+ render_frame_host->browser_accessibility_manager();
+ if (manager)
+ manager->NavigationSucceeded();
}
void WebContentsImpl::DidNavigateMainFramePreCommit(
@@ -3800,6 +3822,17 @@ void WebContentsImpl::DidStartLoading(RenderFrameHost* render_frame_host,
bool to_different_document) {
SetIsLoading(render_frame_host->GetRenderViewHost(), true,
to_different_document, NULL);
+
+ // Notify accessibility that the user is navigating away from the
+ // current document.
+ //
+ // TODO(dmazzoni): do this using a WebContentsObserver.
+ FrameTreeNode* ftn = static_cast<RenderFrameHostImpl*>(render_frame_host)->
+ frame_tree_node();
+ BrowserAccessibilityManager* manager =
+ ftn->current_frame_host()->browser_accessibility_manager();
+ if (manager)
+ manager->UserIsNavigatingAway();
}
void WebContentsImpl::DidStopLoading(RenderFrameHost* render_frame_host) {
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698