Issue 83003006: [telemetry] Re-enable testGotQueryParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83003006: [telemetry] Re-enable testGotQueryParams. (Closed)

Created:
7 years, 1 month ago by dtu

Modified:
7 years ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Re-enable testGotQueryParams. Most of that flow has been rewritten since it was disabled, so assume it's safe to re-enable. The trybot will run the test. Also change the tests to raise MeasurementFailures, since we keep track of failures and errors separately. BUG=288631 TEST=Mac trybot Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238265

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	tools/telemetry/telemetry/page/page_measurement_unittest.py	View	1	3 chunks	+13 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/83003006/60001

7 years ago (2013-12-02 21:36:00 UTC) #3

Message was sent while issue was closed.

Change committed as 238265

Expand Messages | Collapse Messages