Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: sky/framework/sky-element/sky-binder.sky

Issue 829993004: Fix resource clean up in TemplateIterator.close() (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/sky-element/sky-binder.sky
diff --git a/sky/framework/sky-element/sky-binder.sky b/sky/framework/sky-element/sky-binder.sky
index a67861de4d7c72d3419f2c3b6af55b2ae86ec093..7a7914c544f31c60905f44a1f147dafa001a3d11 100644
--- a/sky/framework/sky-element/sky-binder.sky
+++ b/sky/framework/sky-element/sky-binder.sky
@@ -455,10 +455,10 @@ class TemplateIterator {
this.instances.length = 0;
- if (this.ifBinding)
- this.ifBinding.close();
- if (this.binding)
- this.binding.close();
+ if (this.ifObserver)
+ this.ifObserver.close();
+ if (this.valueObserver)
+ this.valueObserver.close();
iterators.delete(this.template);
this.closed = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698